Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the on-screen/virtual keyboard behavior in the Lab UI by allowing the input editor’s soft keyboard to be toggled and by forcing the output editor’s soft keyboard off, while also updating Roslyn/Razor dependencies and adding a few Roslyn accessor helpers used by formatting/cursor-sync logic.
Changes:
- Add a UI toggle to disable/enable the input editor’s on-screen keyboard and persist the preference in local storage; always disable the output editor’s on-screen keyboard.
- Add JS-side logic to enforce
inputmode="none"on Monaco’s native edit context via aMutationObserver. - Update Roslyn/Razor package versions and extend Roslyn access/TreeFormatter span extraction helpers.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/WebAssembly/WebAssembly.csproj | Prevents store link text/icon wrapping in the WebAssembly index footer. |
| src/Shared/Attributes.cs | Adds new attributes for describing generic arguments/method instantiations. |
| src/RoslynAccess/RoslynAccessors.cs | Adds helpers to retrieve syntax from bound nodes/internal symbols. |
| src/Compiler/TreeFormatter.cs | Uses new Roslyn accessor helpers to derive spans from more object kinds. |
| src/App/Lab/Page.razor.js | Adds setVirtualKeyboardDisabled implementation using a MutationObserver. |
| src/App/Lab/Page.razor | Adds keyboard toggle button, persists option, disables VK on output editor init. |
| Directory.Packages.props | Bumps Roslyn/Razor versions via updated build numbers. |
| .globalconfig | Enables IDE0380 as a warning. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.